Skip to content

Add find_package for eigen#569

Merged
kjplows merged 2 commits into
developfrom
bugfix/eigen_patch
Sep 12, 2025
Merged

Add find_package for eigen#569
kjplows merged 2 commits into
developfrom
bugfix/eigen_patch

Conversation

@nathanielerowe

@nathanielerowe nathanielerowe commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

This PR is a fix for building with spack. Historically, we have relied on transitive dependencies even when we need direct dependencies. This gets rid of the following error which occurs at build time:

CMake Error at /daq/software/spack_packages/larreco/10.01.12/linux-almalinux9-x86_64_v2-gcc-12.1.0-r4nhaewmkymcijo6kzkl6ux2vqkxfqaj/lib/larreco/cmake/larrecoTargets.cmake:186 (set_target_properties):
  The link interface of target "larreco::Voronoi_DCEL" contains:

    Eigen3::Eigen

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Call Stack (most recent call first):
  /daq/software/spack_packages/cetmodules/3.26.00/linux-almalinux9-x86_64_v2-gcc-12.1.0-6wueazjwav57juntb6cy4v2kr3fhaxkq/Modules/compat/art/CetCMPCleaner.cmake:71 (_include)
  /daq/software/spack_packages/larreco/10.01.12/linux-almalinux9-x86_64_v2-gcc-12.1.0-r4nhaewmkymcijo6kzkl6ux2vqkxfqaj/lib/larreco/cmake/larrecoConfig.cmake:169 (include)
  /daq/software/spack_packages/cetmodules/3.26.00/linux-almalinux9-x86_64_v2-gcc-12.1.0-6wueazjwav57juntb6cy4v2kr3fhaxkq/Modules/private/CetOverrideFindPackage.cmake:180 (_find_package)
  CMakeLists.txt:61 (find_package)

@nathanielerowe nathanielerowe added the bugfix Addresses one or more bugs label Sep 4, 2025
kjplows
kjplows approved these changes Sep 11, 2025
View reviewed changes

@kjplows kjplows left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- for the online, having more direct dependencies is not an issue

@kjplows

kjplows commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_09_00

@kjplows kjplows moved this to Testing in SBN software development Sep 11, 2025
@FNALbuild

FNALbuild commented Sep 12, 2025

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

FNALbuild commented Sep 12, 2025

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

FNALbuild commented Sep 12, 2025

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

FNALbuild commented Sep 12, 2025

Copy link
Copy Markdown

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

FNALbuild commented Sep 12, 2025

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

FNALbuild commented Sep 12, 2025

Copy link
Copy Markdown

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Testing to To merge in SBN software development Sep 12, 2025
@kjplows
kjplows merged commit fc2a169 into develop Sep 12, 2025
@github-project-automation github-project-automation Bot moved this from To merge to Done in SBN software development Sep 12, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Sep 12, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Sep 18, 2025
@nathanielerowe
nathanielerowe deleted the bugfix/eigen_patch branch October 22, 2025 03:43
@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
@kjplows kjplows added this to the v10_10_02 milestone Jan 16, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in PR archaeology Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kjplows kjplows kjplows approved these changes

Assignees

No one assigned

Labels

bugfix Addresses one or more bugs

Projects

PR archaeology
Status: Done
SBN software development
Status: 2025 PRs

Milestone

v10_10_02

Development

Successfully merging this pull request may close these issues.

3 participants

@nathanielerowe @kjplows @FNALbuild